fixeria has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-msc/+/14465 )
Change subject: libmsc/gsm_09_11.c: drop rudimentary vsub->cgi.lai.lac check
......................................................................
libmsc/gsm_09_11.c: drop rudimentary vsub->cgi.lai.lac check
This check was copy-pasted either from CC, or from SMS handling
code during the initial development of "SS/USSD over GSUP". Now
this is the only one survived after the recent refactoring.
I doubt this is exactly the right way to check whether subscriber
is attached or not. Moreover, this check should rather be done in
a single place, rather then in each CC/SS/SMS handler separately.
Change-Id: I7bd48860e923cb1f1a5bccc4b0f497ec1a7bcf84
---
M src/libmsc/gsm_09_11.c
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c
index b85c742..bcf8dec 100644
--- a/src/libmsc/gsm_09_11.c
+++ b/src/libmsc/gsm_09_11.c
@@ -330,13 +330,6 @@
return NULL;
}
- /* If subscriber is not "attached" */
- if (!vsub->cgi.lai.lac) {
- LOGP(DSS, LOGL_ERROR, "Network-originated session "
- "rejected - subscriber is not attached\n");
- return NULL;
- }
-
/* Obtain an unused transaction ID */
tid = trans_assign_trans_id(net, vsub, TRANS_USSD);
if (tid < 0) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14465
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7bd48860e923cb1f1a5bccc4b0f497ec1a7bcf84
Gerrit-Change-Number: 14465
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: laforge <lafo...@gnumonks.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
