fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14505 )

Change subject: sgsn: add osmo-sgsn.cfg, SGSN_Tests.cfg
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/14505/1/sgsn/osmo-sgsn.cfg
File sgsn/osmo-sgsn.cfg:

https://gerrit.osmocom.org/#/c/14505/1/sgsn/osmo-sgsn.cfg@12
PS1, Line 12: all everything
Same here.


https://gerrit.osmocom.org/#/c/14505/1/sgsn/osmo-sgsn.cfg@50
PS1, Line 50: all everything
This has been deprecated. Let's rather do:

  logging level set-all notice

and then list only those categories where level != NOTICE.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14505
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6da479e35fbe9f861a8bd8e578badcd1563e740f
Gerrit-Change-Number: 14505
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: laforge <lafo...@gnumonks.org>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Jun 2019 11:05:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to