fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14525
Change subject: libvlr/vlr.c: do not expire subscribers if periodic LU is disabled ...................................................................... libvlr/vlr.c: do not expire subscribers if periodic LU is disabled When periodic Location Update is disabled (T3212 = 0), it was noticed that OsmoMSC does expire subscribers quite soon - after 60 seconds (VLR_SUBSCRIBER_LU_EXPIRATION_INTERVAL) since the last LU. In order to avoid that, we need to check T3212 timer value in vlr_subscr_expire_lu(), and if it's equal to 0, do not expire anybody until the explicit IMSI Detach. Change-Id: I2ead2241a3394dbdd5417f4554190df3fd698af2 --- M src/libvlr/vlr.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/25/14525/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 5610cfb..625b699 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -519,8 +519,15 @@ { struct vlr_instance *vlr = data; struct vlr_subscr *vsub, *vsub_tmp; + struct gsm_network *net; struct timespec now; + /* Periodic location update might be disabled from the VTY, + * so we shall not expire subscribers until explicit IMSI Detach. */ + net = vlr->user_ctx; /* XXX move t3212 into struct vlr_instance? */ + if (!net->t3212) + goto done; + if (llist_empty(&vlr->subscribers)) goto done; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14525 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2ead2241a3394dbdd5417f4554190df3fd698af2 Gerrit-Change-Number: 14525 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilira...@gmail.com> Gerrit-MessageType: newchange