pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14568 )
Change subject: bts: Set T200 DCCH values for CCCH ...................................................................... Patch Set 1: So after looking a bit at the related code: bts.c calls libosmocore's lapdm_channel_init2(), which in turn calls get_n200_dcch() which will return -1 for CCH and then in turn lapdm_channel_init2() will return -EINVAL. So I think we should in bts.c only print the log line if t200_by_lchan() returns != -1, and avoid calling lapdm_channel_init2() in that case too. I initially tried avoiding a call to lchan_init_lapdm() in osmo-bts if lchan was CCCH, but it doesn't seem to like that since then lapdm_rll_tx_cb is never called and it seems RACH requests are never handled? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14568 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3d7e1883811acf97aac97325739f2ff97fc2aa08 Gerrit-Change-Number: 14568 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jun 2019 12:15:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
