laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14665 )
Change subject: Transceiver: Support SETFORMAT command ...................................................................... Patch Set 7: I believe I raised this before in some other place: Why are we faling back to a lower version rather than simply failing SETFORMAT for any unknown version? I think it's somewhat odd and dangerous if we have "SETFORMAT 3" and then the TRX returns "OK, I set 2". -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-CC: laforge <lafo...@gnumonks.org> Gerrit-Comment-Date: Sun, 07 Jul 2019 08:03:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
