laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14697 )
Change subject: Encoding: ACK/NACK: always encode with length field present ...................................................................... Patch Set 1: Code-Review+1 it might be worth stating something like "rather than fixing the encoding without length field, let's simply always encode the length field" to the commit log, and have a related comment in the source code indicating that the spec permits for encoding without length field, could be as simple as "/* TODO: implement encoding of ACK/NACK without length field */" -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb Gerrit-Change-Number: 14697 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Comment-Date: Tue, 09 Jul 2019 09:54:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
