laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-bsc/+/14766 )
Change subject: comment and VTY doc tweaks
......................................................................
comment and VTY doc tweaks
Clarify some in-code comments.
Fix descriptions of some handover timers, which still talked of "MO" and "MT"
handover -- which we now call "inter-BSC out" or "inter-BSC in" instead.
Change-Id: I8429a830edd0325893ac90f22fcc05309617bd2d
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/net_init.c
3 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index a464001..d82d1ba 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1505,7 +1505,7 @@
struct llist_head bts_list;
struct llist_head bts_rejected;
- /* shall reference gsm_network_T[] */
+ /* see gsm_network_T_defs */
struct osmo_tdef *T_defs;
enum gsm_chan_t ctype_by_chreq[_NUM_CHREQ_T];
diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index 22618c5..7406a97 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -200,7 +200,8 @@
conn = req->old_lchan->conn;
OSMO_ASSERT(conn && conn->fi);
- /* To make sure we're allowed to start a handover, go through a gscon
event dispatch. */
+ /* To make sure we're allowed to start a handover, go through a gscon
event dispatch. If that is accepted, the
+ * same req is passed to handover_start(). */
osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_HANDOVER_START, req);
}
diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c
index 1ef9bd5..34403fa 100644
--- a/src/osmo-bsc/net_init.c
+++ b/src/osmo-bsc/net_init.c
@@ -26,10 +26,10 @@
#include <osmocom/bsc/neighbor_ident.h>
static struct osmo_tdef gsm_network_T_defs[] = {
- { .T=7, .default_val=10, .desc="inter-BSC Handover MO, HO Required to
HO Command" },
- { .T=8, .default_val=10, .desc="inter-BSC Handover MO, HO Command to
final Clear" },
+ { .T=7, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP
HO Required to HO Command timeout" },
+ { .T=8, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP
HO Command to final Clear timeout" },
{ .T=10, .default_val=6, .desc="RR Assignment" },
- { .T=101, .default_val=10, .desc="inter-BSC Handover MT, HO Request to
HO Accept" },
+ { .T=101, .default_val=10, .desc="inter-BSC/MSC Handover incoming,
BSSMAP HO Request to HO Accept" },
{ .T=3101, .default_val=3, .desc="RR Immediate Assignment" },
{ .T=3103, .default_val=5, .desc="Handover" },
{ .T=3105, .default_val=100, .unit=OSMO_TDEF_MS, .desc="Physical
Information" },
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14766
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8429a830edd0325893ac90f22fcc05309617bd2d
Gerrit-Change-Number: 14766
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@gnumonks.org>
Gerrit-MessageType: merged
