laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14360 )
Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... Patch Set 5: (1 comment) all of your comments adressed in the next version to be pushed in the next few minutes. https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c File src/gsm/cbsp.c: https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c@39 PS5, Line 39: return msgb_alloc_headroom_c(ctx, 65535, 16, name); > Wow, really, that long? well, there can be many cells in a network (real-world GSM networks in Germany used to have something like ~ 8k cells, today with smaller cells likely many more). And most CBSP messages can contain arbitrary-length lists of cell identifiers... The 64k limit is due to the 16bit length field in the protocol. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jul 2019 10:59:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
