pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14769 )
Change subject: neighbor config: allow re-using ARFCN+BSIC pairs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/14769/1/src/osmo-bsc/handover_decision_2.c File src/osmo-bsc/handover_decision_2.c: https://gerrit.osmocom.org/#/c/14769/1/src/osmo-bsc/handover_decision_2.c@903 PS1, Line 903: find_handover_target_cell(&neighbor_bts, &neighbor_cil, I'd usually expect an API to return error/success and then have out parameters set to meaningful values only when needed, that is, upon success. But fine anyway. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bca59ab232eddc74e0d4698efb9c9992443983 Gerrit-Change-Number: 14769 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jul 2019 16:24:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment