neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 )
Change subject: Handle SIP re-INVITEs ...................................................................... Patch Set 3: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/14994/3/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14994/3/src/sip.c@183 PS3, Line 183: // TODO: Tell osmo-bts to stop sending RTP ? you mean tell osmo-msc to tell osmo-bsc to tell osmo-bts to stop sending rtp? is such in the specs? https://gerrit.osmocom.org/#/c/14994/3/src/sip.c@185 PS3, Line 185: // Regular re-INVITE. Just ACK. > BTW, reviewers: […] sounds like a good thing to put in an in-code comment. BTW, I personally prefer '//' comments, but osmocom code style wants us to always use '/* ... */' comments. https://gerrit.osmocom.org/#/c/14994/3/src/sip.c@189 PS3, Line 189: LOGP(DSIP, LOGL_DEBUG, "Sending 200 response to re-INVITE for mode(%u)\n", mode); (looks like we could use a value_string array translating the modes to human-readable strings...) -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 3 Gerrit-Owner: keith <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <ke...@rhizomatica.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2019 16:22:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: keith <ke...@rhizomatica.org> Gerrit-MessageType: comment
