keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 )
Change subject: Add support for MNCC HOLD/RETRIEVE ...................................................................... Patch Set 9: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14996/8/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/14996/8/src/mncc.c@719 PS8, Line 719: /* In case of call waiting/swap, At this point we need to tell the MSC to send > Sorry to say so, but you need to remove this whitespace at the end of the > line (otherwise I'll hate […] yeah.. I already saw it.. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9 Gerrit-Change-Number: 14996 Gerrit-PatchSet: 9 Gerrit-Owner: keith <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <ke...@rhizomatica.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2019 17:14:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment