laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-hlr/+/15042 )
Change subject: Remove undefined param passed to logging_vty_add_cmds
......................................................................
Remove undefined param passed to logging_vty_add_cmds
Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its
parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,
definition in C file doesn't contain "(void)", which means number of
parameters is undefined and thus compiler doesn't complain. Let's remove
parameters from all callers before enforcing "(void)" on it.
Related: OS#4138
Change-Id: I6d0dbbd83ce17ee798bfb6e30378ed1dbae19134
---
M src/hlr.c
M src/hlr_vty.c
M src/hlr_vty.h
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/hlr.c b/src/hlr.c
index 90cbac4..8b9dff1 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -846,7 +846,7 @@
vty_init(&vty_info);
ctrl_vty_init(hlr_ctx);
handle_options(argc, argv);
- hlr_vty_init(&hlr_log_info);
+ hlr_vty_init();
rc = vty_read_config_file(cmdline_opts.config_file, NULL);
if (rc < 0) {
diff --git a/src/hlr_vty.c b/src/hlr_vty.c
index e6567cc..f7c5bc8 100644
--- a/src/hlr_vty.c
+++ b/src/hlr_vty.c
@@ -429,9 +429,9 @@
}
}
-void hlr_vty_init(const struct log_info *cat)
+void hlr_vty_init(void)
{
- logging_vty_add_cmds(cat);
+ logging_vty_add_cmds();
osmo_talloc_vty_add_cmds();
osmo_stats_vty_add_cmds();
diff --git a/src/hlr_vty.h b/src/hlr_vty.h
index 1f3b87f..280b55a 100644
--- a/src/hlr_vty.h
+++ b/src/hlr_vty.h
@@ -35,4 +35,4 @@
int hlr_vty_is_config_node(struct vty *vty, int node);
int hlr_vty_go_parent(struct vty *vty);
-void hlr_vty_init(const struct log_info *cat);
+void hlr_vty_init(void);
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/15042
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I6d0dbbd83ce17ee798bfb6e30378ed1dbae19134
Gerrit-Change-Number: 15042
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@gnumonks.org>
Gerrit-MessageType: merged
