neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15140 )
Change subject: tweak mgcp_parse_audio_ptime_rtpmap() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15140/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15140/1//COMMIT_MSG@12 PS1, Line 12: - instead of strstr("rtpmap"), use osmo_str_startswith("a=rtpmap:") to more > Does spec state there shall be no whitespace at the start of the line? (There are no spaces at SDP line beginnings.) The point being that 'strstr("rtpmap")' would also match these convoluted examples: o=openrtpmaptool 1565090289 1565090290 IN IP4 192.168.11.151 s=rtpmap-test or strstr("ptime") would even match s=sleeptimer i.e. we must not match the middle of a free-format string. The only accurate match is at the start of a line after 'a=' a=rtpmap:123 FOO/8000 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I730111e245da8485c1b5e8811f75d140e379cec6 Gerrit-Change-Number: 15140 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 12 Aug 2019 22:50:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
