pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15166 )

Change subject: gprs_sgsn.c: Warn upon llme free unexpected scenarios
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+2
>
> LGTM.
> We should move the geran stuff behind an if (ran == geran)

What do you mean? the unassign in the lines I changed?

afaiu llme is only available when ran==geran, so it should be practically the 
same and already checked.


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15166
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I0d175501083ce458ff1c07ad38761d2cbf4ea470
Gerrit-Change-Number: 15166
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Aug 2019 09:52:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to