pespin has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15187 )

Change subject: gprs_gmm: Clarify comment during TLLI assignment
......................................................................

gprs_gmm: Clarify comment during TLLI assignment

TS 04.64 sec 7.2.1.1 LLGMM-ASSIGN specifies:
"""
If TLLI Old  all 1's and TLLI New  all 1's then TLLI Old and TLLI New are 
assigned, and TLLI New shall
be used when (re-)transmitting LLC frames. Both TLLI Old and TLLI New shall be 
accepted when received
from the peer. It shall be treated as a TLLI change according to subclause 
8.3.2.
"""

Change-Id: I3a17715bf2dba7b03c1335ad106307eb4d5f564a
---
M src/gprs/gprs_gmm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  lynxis lazus: Looks good to me, approved



diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index c8bc0f7..0fcf1bb 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1794,7 +1794,7 @@
                * foreign TLLI to local TLLI */
                mmctx->gb.tlli_new = gprs_tmsi2tlli(mmctx->p_tmsi, TLLI_LOCAL);

-               /* Inform LLC layer about new TLLI but keep old active */
+               /* Inform LLC layer about new TLLI but keep accepting the old 
one during Rx */
                gprs_llgmm_assign(mmctx->gb.llme, mmctx->gb.tlli,
                                  mmctx->gb.tlli_new);
        }

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15187
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3a17715bf2dba7b03c1335ad106307eb4d5f564a
Gerrit-Change-Number: 15187
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged

Reply via email to