neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15212 )
Change subject: gprs_gmm: Avoid spaces in fsm events and enum strings ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm.c File src/gprs/gprs_gmm.c: https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm.c@110 PS1, Line 110: { PMM_DETACHED, "PMM_DETACH" }, maybe while at it fix to "PMM_DETACHED" (or what Vadim said) https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm_attach.c File src/gprs/gprs_gmm_attach.c: https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm_attach.c@328 PS1, Line 328: { E_VLR_ANSWERED, "VLR_ANSWERED"}, (this could also use OSMO_VALUE_STRING(); IMHO it's an advantage to print exactly the event names as found in the code) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I16ede8bf8352b09bc772fd7b43fad2c2274b3ec1 Gerrit-Change-Number: 15212 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Wed, 14 Aug 2019 23:55:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
