neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15133 )
Change subject: fix memleak: actually free strings in mgcp_codec_reset_all() ...................................................................... fix memleak: actually free strings in mgcp_codec_reset_all() The audio_name and subtype_name are allocated from talloc, so they need to be freed before resetting the codec array. Use mgcp_codec_free() to ensure this. Change-Id: I07f207dcb7ce66bbf3445a30af41e696677b384f --- M src/libosmo-mgcp/mgcp_codec.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_codec.c b/src/libosmo-mgcp/mgcp_codec.c index 30c185c..7f1a6d1 100644 --- a/src/libosmo-mgcp/mgcp_codec.c +++ b/src/libosmo-mgcp/mgcp_codec.c @@ -100,7 +100,9 @@ * \param[out] conn related rtp-connection. */ void mgcp_codec_reset_all(struct mgcp_conn_rtp *conn) { - memset(conn->end.codecs, 0, sizeof(conn->end.codecs)); + int i; + for (i = 0; i < conn->end.codecs_assigned; i++) + codec_free(&conn->end.codecs[i]); conn->end.codecs_assigned = 0; conn->end.codec = NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I07f207dcb7ce66bbf3445a30af41e696677b384f Gerrit-Change-Number: 15133 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-MessageType: merged