pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303 )
Change subject: mncc: do not unregister unregistered osmo fds ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15303/2/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/15303/2/src/mncc.c@327 PS2, Line 327: if (osmo_fd_is_registered(&conn->fd)) Just wondering, we are also unconditionally closing conn->fd.fd. Can it happen that fd.fd exists but fd is not registered? Probably not. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I9742f31a37296fed15d54cf44c1f65b93abb8c8e Gerrit-Change-Number: 15303 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 28 Aug 2019 13:41:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
