neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15306 )

Change subject: sgsn: Introduce test TC_attach_echo_timeout
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

I don't fully comprehend but looks sane enough

https://gerrit.osmocom.org/#/c/15306/1/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/#/c/15306/1/sgsn/SGSN_Tests.ttcn@1562
PS1, Line 1562:            should drop the pdp ctx. Around T3 (3secs) * 6 (+ 
extra, a lot due to OS#4178): */
maybe could f_vty_transceive() to configure a shorter timeout? (to get a 
shorter test run)



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15306
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic31748924e7bf05ea2ccf2b1be0c460eefed5782
Gerrit-Change-Number: 15306
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Aug 2019 03:41:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to