neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15302 )
Change subject: cosmetic: fix formatting in if line ...................................................................... Patch Set 1: Code-Review+1 (1 comment) not really worth the trouble, but whatever https://gerrit.osmocom.org/#/c/15302/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15302/1//COMMIT_MSG@10 PS1, Line 10: Fixes: 2d6a69e69a4b4cb2b8cc63c4810dae44e5a4d8f6 AFAIK the'Fixes:' tag should reference an issue number. I'd rather say "Introduced in eefa...". -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9ee5f4142cacf912145693c72a53c0f531bad2c6 Gerrit-Change-Number: 15302 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Thu, 29 Aug 2019 03:45:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment