laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15307 )

Change subject: Introduce log helper LOGGGSN
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15307/2/include/osmocom/sgsn/gprs_sgsn.h
File include/osmocom/sgsn/gprs_sgsn.h:

https://gerrit.osmocom.org/#/c/15307/2/include/osmocom/sgsn/gprs_sgsn.h@411
PS2, Line 411: ggc->id
it's customary to use (ggc)->id in such macros, as you don't know how exactly 
somebody provides the argument



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15307
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I30f46f44af1d0eee324b1a995c1dad2e1315af7c
Gerrit-Change-Number: 15307
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilira...@gmail.com>
Gerrit-CC: laforge <lafo...@gnumonks.org>
Gerrit-Comment-Date: Fri, 30 Aug 2019 08:24:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to