dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15313 )
Change subject: pySim-prog: Use CSV format with headers ...................................................................... Patch Set 1: (1 comment) I think I found whats wrong. (See comment) https://gerrit.osmocom.org/#/c/15313/1/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/#/c/15313/1/pySim/cards.py@572 PS1, Line 572: self._scc.verify_chv(0x0A, p['adm1']) I think this should be: self._scc.verify_chv(0x0A, h2b(p['adm1'])) This also explains the problems with sysmo-usim-tool. The authentication here fails, and then the tests for sysmo-usim-tool also block because sysmo-usim-tool detects that only 2 or less authentication attempts are left. PySim won't complain, after the 3rd run of the test the card will lock down. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0d317ea51d0cf582b82157eec6cdec074001a236 Gerrit-Change-Number: 15313 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 02 Sep 2019 11:47:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
