lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15423 )
Change subject: tbf_dl: make preemptive retransmission optional ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/15423/3/src/tbf_dl.cpp File src/tbf_dl.cpp: https://gerrit.osmocom.org/#/c/15423/3/src/tbf_dl.cpp@434 PS3, Line 434: !m_window.window_empty() && bts->bts_data()->dl_tbf_preemptive_retransmission nitpick: I would first check for dl_tbf_preemptive_retransmission -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id08aed513d4033aa0d4324c6ce07cbb2852f2f92 Gerrit-Change-Number: 15423 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 10 Sep 2019 13:23:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
