neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15473 )
Change subject: iu_client: introduce ranap_iu_tx_release_free() ...................................................................... Patch Set 1: Code-Review+1 (3 comments) It works and the code looks sane; but after refactoring these things in osmo-msc, I would prefer to have an FSM instance instead of "manual timers". FSMs are for me the shiny new and better way to manage timeouts and async events, and setting up timers is more like the old and weird way. If it were me, I would sooner or later adopt similar FSM layering as in osmo-msc, like sccp_ran (SCCP conn state), ran_peer (hnb/PCU peer state), and a subscriber FSM (msc_i/msc_a transposed to the SGSN land). Whichever layer needs to wait for a release can then just stick around until the message came in or a timeout has passed. I accept that it would be more work than tweaking the current code base, but I expect it to pay off in the long run. That would be my recommendation, but I leave it up to you. https://gerrit.osmocom.org/#/c/15473/1/include/osmocom/ranap/iu_client.h File include/osmocom/ranap/iu_client.h: https://gerrit.osmocom.org/#/c/15473/1/include/osmocom/ranap/iu_client.h@81 PS1, Line 81: int timeout); indent off-by-one https://gerrit.osmocom.org/#/c/15473/1/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15473/1/src/iu_client.c@134 PS1, Line 134: ctx); indent off-by-one https://gerrit.osmocom.org/#/c/15473/1/src/iu_client.c@500 PS1, Line 500: int timeout) indent -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15473 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I349e2c61ba0131e233b7ab927dfced0bd461dd8f Gerrit-Change-Number: 15473 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: laforge <lafo...@gnumonks.org> Gerrit-Comment-Date: Wed, 11 Sep 2019 12:23:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
