pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15490 )
Change subject: vlr: gmm_cause_to_fsm_and_mm_cause() drop fsm_cause_p argument ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/15490/1/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/15490/1/src/libvlr/vlr.c@925 PS1, Line 925: if (!gsm48_rej_p) IMHO It doesn't make to call this function with gsm48_rej_p being NULL, so you can drop this. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie4720ad40ef7bcfc528d8d63bfc606c9c0545fb2 Gerrit-Change-Number: 15490 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2019 11:46:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
