lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15483 )
Change subject: Iu: implement a user inactivity timer ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15483/2/src/sgsn/gprs_mm_state_iu_fsm.c File src/sgsn/gprs_mm_state_iu_fsm.c: https://gerrit.osmocom.org/#/c/15483/2/src/sgsn/gprs_mm_state_iu_fsm.c@50 PS2, Line 50: static const struct RANAP_Cause user_inactive_cause = { > why static? it's fine having it in the stack right? shouldn't be static. passing it down the layers isn't a problem. it will be only used while calling the function and later parsed into a pdu -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I66c2ac0350cb074aefd9a22c5121acf723f239d3 Gerrit-Change-Number: 15483 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2019 17:16:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment