neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15544 )
Change subject: catch GSUP auth result without auth_fsm ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15544/1/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/15544/1/src/libvlr/vlr.c@760 PS1, Line 760: if (!auth_fi) { > Is it clear how can this happen? How it comes the subscriber has no fi? or it > is fixing an unknown s […] See the referenced issue -- I asked the submitter for more details, but until then I'm at a loss. All I know at this point is that it makes a lot of sense to not assume an auth_fsm is present just because some external program sent a specific GSUP message. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1995d8f68cfde1140968fb9a97bd054de950de2e Gerrit-Change-Number: 15544 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 17 Sep 2019 23:49:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
