pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15515 )
Change subject: radioInterfaceMulti: Check equals zero explicitly ...................................................................... radioInterfaceMulti: Check equals zero explicitly It's not a pointer check or a boolean expression, in here we really check chan index is 0, so it's more clear doing so this way like it's done in all other places. Change-Id: I83b14487d14ba8272f58796f640f58a88891e532 --- M Transceiver52M/radioInterfaceMulti.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/Transceiver52M/radioInterfaceMulti.cpp b/Transceiver52M/radioInterfaceMulti.cpp index 7c1ee74..c41ec22 100644 --- a/Transceiver52M/radioInterfaceMulti.cpp +++ b/Transceiver52M/radioInterfaceMulti.cpp @@ -400,7 +400,7 @@ double RadioInterfaceMulti::setRxGain(double db, size_t chan) { - if (!chan) + if (chan == 0) return mDevice->setRxGain(db); else return mDevice->getRxGain(); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I83b14487d14ba8272f58796f640f58a88891e532 Gerrit-Change-Number: 15515 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-MessageType: merged