neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15560 )
Change subject: logging: Introduce mutex API to manage log_target in multi-thread envs ...................................................................... Patch Set 3: (1 comment) I hope this isn't annoying you -- but... https://gerrit.osmocom.org/#/c/15560/2/include/osmocom/core/logging.h File include/osmocom/core/logging.h: https://gerrit.osmocom.org/#/c/15560/2/include/osmocom/core/logging.h@392 PS2, Line 392: void log_tgt_mutex_unlock(void); > Same as explained above. […] I understand. Yet, even easier would be without recompile. Evaluating a bool is not a performance penalty. In an environment like a sysmoBTS, or maybe even just if users installed deb packages and are working on that, it can be really cumbersome to have to recompile libosmocore (and everything else) just to switch on debugging. We have similar debugging bools, see for example osmo_fsm_log_addr(). No reply on the use of different kinds of symbols? I know you can do better ;) Not sure if it's worth spending time and discussing, but I believe my two points are valid... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id7711893b34263baacac6caf4d489467053131bb Gerrit-Change-Number: 15560 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Wed, 18 Sep 2019 13:48:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Gerrit-MessageType: comment
