laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15704 )
Change subject: sgsn_mm_ctx_alloc(): check for unallocated fsms ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15704/1/src/sgsn/gprs_sgsn.c File src/sgsn/gprs_sgsn.c: https://gerrit.osmocom.org/#/c/15704/1/src/sgsn/gprs_sgsn.c@270 PS1, Line 270: osmo_fsm_inst_free(ctx->iu.mm_state_fsm); > it does not guard against it. it would be worth a separate change to libosmocore to fix that. However, applications still must have their own null-checks for the time being, as long as they still work with older released libosmocore versions :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I867612a60236eaf7009400c92f5d871006aaf008 Gerrit-Change-Number: 15704 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Tue, 08 Oct 2019 20:38:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment