osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15761 )
Change subject: docker: only one apt/pip cmd for installing deps ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ci/+/15761/2/docker/Dockerfile_osmocom_jenkins.amd64 File docker/Dockerfile_osmocom_jenkins.amd64: https://gerrit.osmocom.org/c/osmo-ci/+/15761/2/docker/Dockerfile_osmocom_jenkins.amd64@14 PS2, Line 14: asciidoc \ > I think it makes sense to write to the right of each line who requires the > dependency, specially now […] This would be great, but I'm not aware of a syntax where this is possible. DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \ asciidoc \ # some comment asciidoc-dblatex \ autoconf \ ... gives: Error response from daemon: Dockerfile parse error line 15: unknown instruction: ASCIIDOC-DBLATEX -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I190e62dd39533b284c93107607dac24ece6d7be6 Gerrit-Change-Number: 15761 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 11 Oct 2019 11:13:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
