fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15805 )
Change subject: vty.c: remove assert for always true condition ...................................................................... Patch Set 1: (1 comment) I would rather use a variable of a signed type and keep the checks. https://gerrit.osmocom.org/c/osmo-bts/+/15805/1/src/common/vty.c File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/15805/1/src/common/vty.c@a1606 PS1, Line 1606: get_string_value Well, theoretically this function can return a negative number. This could be even possible with an older version of libosmocore (see I5f4e2d16c62a2d22717989c6acc77450957168cb and preceding changes). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4d30afacfab93051868ae8f462cee9ad3dbc7fd0 Gerrit-Change-Number: 15805 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Fri, 18 Oct 2019 12:01:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
