ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15807 )
Change subject: osmo-bts-trx/scheduler: refactor Uplink measurement processing ...................................................................... Patch Set 3: > when it comes to block-diagonal interleaving (which is used on > TCH/F and TCH/H channels), the results are incorrect. Could you explain why the result is no correct? If that's because of each burst affecting two frames - why not just have an avg counter per frame and add values to them accordingly? The code can be made cleaner than it is now, but there will be no need for traversing of a list. If there is something I missed why the above can't be done and we do need to store values - why not use an array? We know that we need 8 values max, so why not allocate an array of 8 elements to avoid linked list operations? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6bc511223069f66b49109d3267bee7bd89585713 Gerrit-Change-Number: 15807 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <axilira...@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: ipse <alexander.cheme...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sat, 19 Oct 2019 12:20:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
