pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15845 )
Change subject: also log MNCC_SETUP_REQ ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/15845/1/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/15845/1/src/libmsc/gsm_04_08_cc.c@1964 PS1, Line 1964: LOG_TRANS_CAT(trans, DMNCC, LOGL_DEBUG, "rx %s\n", get_mncc_name(msg->msg_type)); Wouldn't make more sense to put it before the if conditon immediatelly above to have first printed what was received and later what failed as a consequence? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1495dd562a06cf6c1e9453a1fe111bdf8f4be081 Gerrit-Change-Number: 15845 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 23 Oct 2019 13:51:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
