laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15847 )
Change subject: log: RANAP encode: use RANAP message names instead of BSSAP ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/15847/1/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/15847/1/src/libmsc/ran_msg_iu.c@402 PS1, Line 402: LOG_RAN_IU_ENC(caller_fi, LOGL_DEBUG, "DirectTransfer\n"); > When I wrote the RAN message de/encoding, I decided to put the string > constants directly in the de/e […] OT: wireshark has value_string_ext for that, which builds (AFAIR) hash tables or some other more efficient data structures at program statup time. Feel free to consider something like that for libosmocore. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib0e0630d775a28958ea86802f70cbeec07087f91 Gerrit-Change-Number: 15847 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2019 07:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Gerrit-MessageType: comment
