pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15833 )
Change subject: fsm: add osmo_fsm_set_term_stops_actions() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/15833/1/src/fsm.c File src/fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/15833/1/src/fsm.c@221 PS1, Line 221: void osmo_fsm_set_term_stops_actions(bool term_stops_actions) > Why would you want to dispatch events or allow state changes on FSM instances > after osmo_fsm_inst_te […] Ok I see your point here. Then I guess at some point in the future we should deprecate this API and set the new behavior as default. I'm simply trying to avoid having tons of APIs on each main.c. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0adc13a1a998e953b6c850efa2761350dd07e03a Gerrit-Change-Number: 15833 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2019 11:48:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Gerrit-MessageType: comment