pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15847 )
Change subject: log: RANAP encode: use RANAP message names instead of BSSAP ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/15847/1/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/15847/1/src/libmsc/ran_msg_iu.c@402 PS1, Line 402: LOG_RAN_IU_ENC(caller_fi, LOGL_DEBUG, "DirectTransfer\n"); > OT: wireshark has value_string_ext for that, which builds (AFAIR) hash tables > or some other more eff […] Can we then at least use Can we then use strings from value_string directly so we don't duplicate string names? like: "%s\n", ran_msg_type_names[RAN_MSG_CIPHER_MODE_COMMAND] instead of "SecurityModeCommand\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib0e0630d775a28958ea86802f70cbeec07087f91 Gerrit-Change-Number: 15847 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2019 11:53:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment