laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/15845 )
Change subject: also log MNCC_SETUP_REQ
......................................................................
also log MNCC_SETUP_REQ
If an incoming MNCC_SETUP_REQ ends up in Paging (as usually it does), the early
return so far skipped logging of that MNCC message. Add this logging.
Change-Id: I1495dd562a06cf6c1e9453a1fe111bdf8f4be081
---
M src/libmsc/gsm_04_08_cc.c
M tests/msc_vlr/msc_vlr_test_call.err
2 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
pespin: Looks good to me, approved
diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index c50ec7f..a90ddce 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -1941,6 +1941,9 @@
/* If subscriber has no conn */
if (!msc_a) {
+ /* This condition will return before the common logging
of the received MNCC message below, so
+ * log it now. */
+ LOG_TRANS_CAT(trans, DMNCC, LOGL_DEBUG, "rx %s\n",
get_mncc_name(msg->msg_type));
if (vsub->cs.is_paging) {
LOG_TRANS(trans, LOGL_DEBUG,
diff --git a/tests/msc_vlr/msc_vlr_test_call.err
b/tests/msc_vlr/msc_vlr_test_call.err
index 4724ec6..4f8f925 100644
--- a/tests/msc_vlr/msc_vlr_test_call.err
+++ b/tests/msc_vlr/msc_vlr_test_call.err
@@ -630,6 +630,7 @@
DREF VLR subscr IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 +
mncc_tx_to_gsm_cc: now used by 2 (attached,mncc_tx_to_gsm_cc)
DREF VLR subscr IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 + CC: now
used by 3 (attached,mncc_tx_to_gsm_cc,CC)
DCC trans(CC:NULL IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100
callref-0x423 tid-255) New transaction
+DMNCC trans(CC:NULL IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100
callref-0x423 tid-255) rx MNCC_SETUP_REQ
DPAG Paging: IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 for MNCC:
establish call: Starting paging
paging request (CALL_CONVERSATIONAL) to
IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 on UTRAN-Iu
strcmp(paging_expecting_imsi, vsub->imsi) == 0
@@ -1057,6 +1058,7 @@
DREF VLR subscr IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 +
mncc_tx_to_gsm_cc: now used by 2 (attached,mncc_tx_to_gsm_cc)
DREF VLR subscr IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 + CC: now
used by 3 (attached,mncc_tx_to_gsm_cc,CC)
DCC trans(CC:NULL IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100
callref-0x423 tid-255) New transaction
+DMNCC trans(CC:NULL IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100
callref-0x423 tid-255) rx MNCC_SETUP_REQ
DPAG Paging: IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 for MNCC:
establish call: Starting paging
paging request (CALL_CONVERSATIONAL) to
IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 on UTRAN-Iu
strcmp(paging_expecting_imsi, vsub->imsi) == 0
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15845
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1495dd562a06cf6c1e9453a1fe111bdf8f4be081
Gerrit-Change-Number: 15845
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
