neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15917 )
Change subject: osmo_interact_vty.py: fix py3 encoding bug
......................................................................
osmo_interact_vty.py: fix py3 encoding bug
That code in common.py is hit when invoking via osmo_interact_vty.py. It has a
unicode string already, its attempt to decode hits a python exception (no
'decode' method).
Must be a long standing bug that no-one saw because we're only ever using
the osmo_verify_transcript_vty.py variant.
Change-Id: I1b4a629f12863c498a8681b555f57b4e255cebfb
---
M osmopy/osmo_interact/common.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests
refs/changes/17/15917/1
diff --git a/osmopy/osmo_interact/common.py b/osmopy/osmo_interact/common.py
index 39163a2..cc7e190 100644
--- a/osmopy/osmo_interact/common.py
+++ b/osmopy/osmo_interact/common.py
@@ -429,7 +429,7 @@
for f_path in (cmd_files or []):
with open(f_path, 'r') as f:
- interact.feed_commands(output,
f.read().decode('utf-8').splitlines())
+ interact.feed_commands(output, f.read().splitlines())
if not (cmd_str or cmd_files):
while True:
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15917
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: I1b4a629f12863c498a8681b555f57b4e255cebfb
Gerrit-Change-Number: 15917
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-MessageType: newchange
