fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15911 )
Change subject: fix upgrade to version 2: imei column default value ...................................................................... Patch Set 1: (1 comment) Adding Oliver, as he is the author of the related code (to my best knowledge). https://gerrit.osmocom.org/c/osmo-hlr/+/15911/1/src/db.c File src/db.c: https://gerrit.osmocom.org/c/osmo-hlr/+/15911/1/src/db.c@a302 PS1, Line 302: default NULL Shouldn't IMEI actually be NULL by default? AFAIK, storing IMEI(SV) is an optional feature, so what if this is exactly the correct behaviour, and we also need to add this statement to 'stmt_bootstrap_sql'? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/15911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I68a00014a3d603fcba8781470bc5285f78b538d0 Gerrit-Change-Number: 15911 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Thu, 31 Oct 2019 18:23:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
