fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/15921 )

Change subject: gsm_data.h: Remove unused field classmark from 
gsm_subscriber_connection
......................................................................


Patch Set 1:

Not sure if that's the right approach. In the same patch set you're parsing the 
MS Power Class from the Classmark and storing it in the same place. Some day 
somebody else would need some other field from the Classmark. Let's rather keep 
this field updated?


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15921
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If2826a8f334afabfa3a0198a0bc1eed009962c81
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilira...@gmail.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 18:48:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to