laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15947 )
Change subject: add sdp_msg API: SDP parsing/composition ...................................................................... Patch Set 1: doesn't it much rather make sense to have at least a helper library containing those things that you are copy+pasting here? something like libosmo-sdp-utils, which then can be used by any of the actual parser codebases? Copy+Pasting of such code really hurts me :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If3ce23cd5bab15e2ab4c52ef3e4c75979dffe931 Gerrit-Change-Number: 15947 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Mon, 04 Nov 2019 10:16:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
