pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15957 )
Change subject: utils.h: add OSMO_NAME_C_IMPL() macro ...................................................................... Patch Set 3: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/15957/3/include/osmocom/core/utils.h File include/osmocom/core/utils.h: https://gerrit.osmocom.org/c/libosmocore/+/15957/3/include/osmocom/core/utils.h@300 PS3, Line 300: if (INITIAL_BUFSIZE > 0) { \ better use (INITIAL_BUFSIZE) https://gerrit.osmocom.org/c/libosmocore/+/15957/3/include/osmocom/core/utils.h@324 PS3, Line 324: if (!ON_ERROR) \ Probably add () here, otherwise something in there may take higher priority than the negation mark. https://gerrit.osmocom.org/c/libosmocore/+/15957/3/tests/utils/utils_test.c File tests/utils/utils_test.c: https://gerrit.osmocom.org/c/libosmocore/+/15957/3/tests/utils/utils_test.c@1127 PS3, Line 1127: whitespace -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ida5ba8d9640ea641aafef0236800f6d489d3d322 Gerrit-Change-Number: 15957 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 05 Nov 2019 15:39:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
