fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16020 )

Change subject: hlr: stop on various failures
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16020/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16020/1//COMMIT_MSG@9
PS1, Line 9: tests hard to analyse
Do you have VERDICTOP in your FileMask / ConsoleMask? I find it very useful, 
because you can see all setverdict() invocations. Even if a test case continues 
after a failure.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16020/1/hlr/HLR_Tests.ttcn
File hlr/HLR_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16020/1/hlr/HLR_Tests.ttcn@575
PS1, Line 575: "Unexpected GSUP"
Let's log received message. That's the first thing I would want to see while 
investigating a failed test case...



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16020
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I804aca84d0ccf4767a5c097cf6c882ccbd87c4e1
Gerrit-Change-Number: 16020
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Comment-Date: Mon, 11 Nov 2019 08:45:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to