neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15946 )
Change subject: BSSMAP: decode Codec List (BSS Supported) ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/15946/1/src/libmsc/ran_msg_a.c File src/libmsc/ran_msg_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/15946/1/src/libmsc/ran_msg_a.c@127 PS1, Line 127: /* This IE is not critical, do not abort with error. */ > then probably set log level as WARN/NOTICE? I still think it's an error, because the IE was present, but wasn't decodable. We can continue but might end up with a working phone call, or we might end up with codec mismatches or codecs that the BSS doesn't support. I chose to continue to maybe provide the user with a working setup "by coincidence", but the IE was broken. https://gerrit.osmocom.org/c/osmo-msc/+/15946/1/src/libmsc/ran_msg_a.c@129 PS1, Line 129: ran_dec_msg.compl_l3.codec_list_bss_supported = &codec_list_bss_supported; > I have the feeling that's intended and fine here. […] ran_decoded() is the only scope that is using the decoded message. It is intended this way to avoid a lot of allocation and ownership issues. So, to decode a RAN message, the caller provides a callback which ran_decoded() below invokes. Anything that should remain after the callback returns must be copied. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I66c735c79e982388f06b5de783aa584c9d13569e Gerrit-Change-Number: 15946 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Mon, 11 Nov 2019 20:33:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment