neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15948 )
Change subject: MNCC: add optional SDP to the socket protocol ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/15948/1/src/libmsc/mncc.c File src/libmsc/mncc.c: https://gerrit.osmocom.org/c/osmo-msc/+/15948/1/src/libmsc/mncc.c@266 PS1, Line 266: * char sdp[] starts with a '\0'. */ > for performance reasons I would expect at some point msgb cease to be > zero-initialized. […] The core problem here: I must not assume anything about bytes that remain after the "official" data section in the msgb. So I'll think of a different solution. (We were discussing how msgb might change in API. You are saying that it might not be zero initialized at some point. But also we might choose to randomize unused data for security testing. All that is moot, the byte after the data section in the buffer must not ever matter / be assumed to be anything / be accessed in the first place. Even though it might be an allocated byte of the msgb, the fact that it was never msgb_put() or is later removed again makes it a no-go byte.) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie16f0804c4d99760cd4a0c544d0889b6313eebb7 Gerrit-Change-Number: 15948 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 11 Nov 2019 20:47:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Gerrit-MessageType: comment
