pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16032 )
Change subject: msc: add sdp to MNCC ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16032/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16032/1//COMMIT_MSG@13 PS1, Line 13: These changes still work with current osmo-msc master that doesn't send SDP / Will it make tests again osmo-msc latest to fail then? In that case you should add some module param to avoid sending it, and set it to some value in docker-playground.git and use sed in one of the jenkins.sh to modify the value. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9568c8927507e161aadfad1a4d20aa896d8ae30 Gerrit-Change-Number: 16032 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2019 10:30:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
