fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16021 )
Change subject: hlr: add tests for GSUP proxy routing ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16021/1/hlr/HLR_Tests.ttcn File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16021/1/hlr/HLR_Tests.ttcn@433 PS1, Line 433: GSUP.send(valueof(ts_GSUP_UL_REQ(imsi, source_name := source_name))); > Don't mix position and keyword arguments. Why not? IMSI is a mandatory argument, the second one is optional. I don't see any problems here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16021/1/hlr/HLR_Tests.ttcn@572 PS1, Line 572: tr_GSUP_PROC_SS_RES How about this branch? I see that it's commented out, but maybe some day we will find a way to use 'decmatch'. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3728776d862c5e5fa7628ca28d74c1ef247459fa Gerrit-Change-Number: 16021 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sat, 16 Nov 2019 13:32:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
