fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16067 )
Change subject: scheduler_trx.c: avoid division by zero when calculating BER ...................................................................... Patch Set 1: Code-Review-1 (1 comment) The fix is incomplete. https://gerrit.osmocom.org/c/osmo-bts/+/16067/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/16067/1/src/osmo-bts-trx/scheduler_trx.c@1221 PS1, Line 1221: trx_loop_amr_input As far as I can see, this function is also used in rx_tchh_fn(), so that invocation needs to be fixed too. Let's move the above checks to trx_loop_amr_input(), and simply pass both n_errors and n_bits_total. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1c0731b9a60be4b8c0c84b85b4403168120ceacd Gerrit-Change-Number: 16067 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 19 Nov 2019 06:20:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
