fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16156 )
Change subject: logging.h: define ansi color constants ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/16156/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/16156/2//COMMIT_MSG@12 PS2, Line 12: the "LOG" prefix Do we really need to expose these color constants? If no, you can just put them into logging_internal.h, so there would be no need to use 'OSMO_' prefix. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I03b6b1f73ae7ee61d37ff921e071a3d0881d3e9a Gerrit-Change-Number: 16156 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Fri, 22 Nov 2019 09:01:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
